Skip to content

Cherry pick PR #8527: Implement StarboardBridge.java::requestStop()#10040

Draft
cobalt-github-releaser-bot wants to merge 1 commit intomainfrom
cherry-pick-main-8527
Draft

Cherry pick PR #8527: Implement StarboardBridge.java::requestStop()#10040
cobalt-github-releaser-bot wants to merge 1 commit intomainfrom
cherry-pick-main-8527

Conversation

@cobalt-github-releaser-bot
Copy link
Copy Markdown
Collaborator

@cobalt-github-releaser-bot cobalt-github-releaser-bot commented Apr 14, 2026

Refer to the original PR: #8527

This was unimplemented due to unknown usage. Now we know there are production usage of it due to dependency by StandalonePlayerActivity.

Bug: 470853890

@johnxwork @anonymous1-me
Implement StarboardBridge.java::requestStop() (#8527)
4c7d849 
This was unimplemented due to unknown usage. Now we know there are
production usage of it due to dependency by StandalonePlayerActivity.

Bug: 470853890
(cherry picked from commit 64bf60a)
@cobalt-github-releaser-bot
Copy link
Copy Markdown
Collaborator Author

cobalt-github-releaser-bot commented Apr 14, 2026

MERGE CONFLICT CAT

Caution

There were merge conflicts while cherry picking! Check out cherry-pick-main-8527 and fix the conflicts before proceeding. Check the log at https://github.com/youtube/cobalt/actions/runs/24424820122 for details.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026

🤖 Gemini Suggested Commit Message

android: Implement StarboardBridge requestStop

The requestStop() method in StarboardBridge.java was an unimplemented
no-op. It is now implemented to correctly handle application stop
requests. This is required by production usage, specifically by
StandalonePlayerActivity, to ensure proper termination of the application
activity and removal from recent tasks.

Bug: 470853890

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnxwork johnxwork Awaiting requested review from johnxwork

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cobalt-github-releaser-bot @johnxwork